search

Azure / appcat-rulesets

Repository for maintaining Rulesets for Windup
Eclipse Public License 2.0
6 stars 10 forks source link

Config server usage should be reported on for spring boot apps #128

Closed agoncal closed 1 year ago

agoncal commented 1 year ago

Fix #125

KaiqianYang commented 1 year ago

The PR is mainly detecting config server server-side app. I'll new a PR for config server client-side app, detecting dependency like spring-cloud-starter-config

agoncal commented 1 year ago

@KaiqianYang the client side is already detected in the technology-usage/configuration-management ruleset:

Are you suggesting that we add a new rule detecting server side to this ruleset and then overrid it for Azure ?

KaiqianYang commented 1 year ago

@KaiqianYang the client side is already detected in the technology-usage/configuration-management ruleset:

Are you suggesting that we add a new rule detecting server side to this ruleset and then overrid it for Azure ?

@agoncal Oh client-side rule is already there, good. Yes, it would be good that we add a new rule detecting server side to this ruleset and then override it for Azure. But staying in this spring-boot-to-azure-config-server ruleset is also ok. WDYT?

Mainly I am suggesting that we enrich messages in this PR. Because ASA has different recommendations for config server server-side and client-side app, by enriching messages, we can make it clear in AppCat.

For server-side:

Config Server is discovered to be in use. If you are migrating to Azure Spring Apps, Config Server (Standard Tier) or Application Configuration Service (Enterprise Tier) will be hosted for you. You can just configure the config server after creating an Azure Spring Apps instance. Prepare the Spring Cloud Config server

For client-side:

If you are migrating to Azure Spring Apps, the connection info of Config Server will be injected upon app start. Find any explicit configurations of config server connection info and remove them. Configure the config server after creating an Azure Spring Apps instance

Above are messages in Azure Migrate polished by Tony, may be good references.