Azure / appcat-rulesets

Repository for maintaining Rulesets for Windup
Eclipse Public License 2.0
6 stars 10 forks source link

add restricted config rule for Azure Spring Apps #136

Closed KaiqianYang closed 1 year ago

KaiqianYang commented 1 year ago

https://github.com/windup/windup-rulesets/pull/1017

agoncal commented 1 year ago

@KaiqianYang I'm confused why you created a PR on the WindUp repo instead of AppCAT. Any rule falling into rules/rules-reviewed/azure or rules/rules-overridden-azure should be created into our AppCAT repo, and then, contributed back to WindUp

KaiqianYang commented 1 year ago

@KaiqianYang I'm confused why you created a PR on the WindUp repo instead of AppCAT. Any rule falling into rules/rules-reviewed/azure or rules/rules-overridden-azure should be created into our AppCAT repo, and then, contributed back to WindUp

@agoncal Yeah, I agree, it's better. Have closed that PR on WindUp side and opened it in AppCat https://github.com/Azure/appcat-rulesets/pull/148