search

Azure / appcat-rulesets

Repository for maintaining Rulesets for Windup
Eclipse Public License 2.0
6 stars 8 forks source link

Refactors the existing JNI rule #72

Closed showpune closed 1 year ago

showpune commented 1 year ago

For issue https://github.com/Azure/windup-rulesets/issues/10

In Java, check the Process, ProcessHandler and ProcessBuilder usage

agoncal commented 1 year ago

@showpune this is enhancing an existing WindUp rule. What about doing to contribution in the WindUp repo itself ? If not, we will have to synch this rule back.

Could you also get rid of the CDATA and use Markdown for the message (see https://github.com/Azure/windup-rulesets/issues/44) ?

showpune commented 1 year ago

@agoncal , yes it is enhancing an existing WindUp rule and check the external worker process usage in Java, we can merge it into Azure Repo first and merge it back to windup repo?

agoncal commented 1 year ago

@showpune today we still don't have the process to merge PRs back to the WindUp repo. So it will take longer than the other way round. As this rule will have to be overridden anyway, I would start by pushing this enhancement in the common WindUo repo, and then overrid it in our repo (even if the rule is not merged in WindUp yet, the overriding mecanism will work anyway). So I feel it's a win-win: WindUp has an enchanced existing rule, we have our new rule, and the merge mecanism from WindUp repo to our repo is already in place.

showpune commented 1 year ago

New PR https://github.com/windup/windup-rulesets/pull/995 to merge back to windup