search

Azure / appcat-rulesets

Repository for maintaining Rulesets for Windup
Eclipse Public License 2.0
6 stars 8 forks source link

Refactors the existing Java FX rule #76

Closed agoncal closed 1 year ago

agoncal commented 1 year ago

@KaiqianYang as we discussed, I've refactored the existing Java FX rule that you've created. I got rid of the source (springboot) so it becomes generic to all Azure targets. And because the rule already existed in WindUp, I've moved it to technology-usage and override it. I've also reword the message.

Let me know what you think.

brunoborges commented 1 year ago

I think this rule (and the Swing one too) should be reevaluated.

  1. Most customers will not have JavaFX in their web applications;
  2. If anything, a customer may actually be using a JavaFX "utility" API for some odd reason, but unlikely to be a desktop app.
  3. There is the case where a JavaFX application can actually be rendered over the Web using tools like JPro.

For these reasons, I believe rules that dictate that "if <javafx/swing/awt> therefore " is wrong. There are plenty of APIs from desktop-ish frameworks that can be useful on a Web app, not to mention the fact some frameworks can actually transform/render desktop apps over the Web with HTML5/JS.

I'd say we should ease the message here at the very least, make it informational only, and that the customer just needs to be aware of the API usage, but the message should not say "it does not work".

agoncal commented 1 year ago

@brunoborges makes sense.

BTW I've worked on this rule because the AirSonic app that we bundle in CAT has a Swing front-end ;o)