Closed KaiqianYang closed 1 year ago
Is there a better way to identify presence of libraries and then produce a message?
@brunoborges I think this is the best way because:
<file>
will look for any file located in the project/artifact (inside the WEB-INF/lib
for example), so transitive dependencies will work<project>
will look for the dependencies in the pom.xml
(or Graddle) but it will not deal with transitive dependencies@KaiqianYang as discussed, I really wonder if we need these rules. At the end of the day, they are just <hint title="HTTP Client found" category-id="information" effort="0">
, which means information. This is already done by WindUp itself.
I think our rules could be potential
at least, but not information
as we don't add any added value.
Feign is a different beast (and we already have a rule for SpringBoot https://github.com/Azure/windup-rulesets/blob/main/rules/rules-reviewed/azure/springboot/spring-boot-to-azure-feign.windup.xml) but discovering HTTP frameworks such as Axis, doesn't bring too much value for the users.
WDYT ?
@KaiqianYang as discussed, I really wonder if we need these rules. At the end of the day, they are just
<hint title="HTTP Client found" category-id="information" effort="0">
, which means information. This is already done by WindUp itself.I think our rules could be
potential
at least, but notinformation
as we don't add any added value.Feign is a different beast (and we already have a rule for SpringBoot https://github.com/Azure/windup-rulesets/blob/main/rules/rules-reviewed/azure/springboot/spring-boot-to-azure-feign.windup.xml) but discovering HTTP frameworks such as Axis, doesn't bring too much value for the users.
WDYT ?
Hi @agoncal, I am thinking to drop this PR for now
@kthatipally agree. We can drop it for now. We might have a look into more detail later
Recommend to ensure dependent service connectivity