Fix bug in determining frontend to use when no ingress is present on cluster

[akshaysngupta]

Checklist

• [x] The title of the PR is clear and informative
• [x] If applicable, the changes made in the PR have proper test coverage
• [x] Issues addressed by the PR are mentioned in the description followed by Fixes.

Description

This PR fixes a bug which was introduced as part of changes to support Private Only Application Gateway.

When a cluster doesn't have any/valid ingresses, then AGIC adds a default listener to the AppGW as AppGW requires a listener. To select what frontend IP configuration to use, AGIC checks if

• if UsePrivateIP environment variable is set, then use private IP
• if public IP is present, then use public IP as that was the default behavior before
• otherwise use private IP In a recent change to support private only appgw, a bug got introduced in which AGIC was incorrectly looking for presence of public IP frontend by passing wrong arguments.

In following image, true corresponds to finding a private frontend.

This was causing a panic as denoted in the attached issue. Because AGIC was looking for private IP instead public IP, it was returning nil and dereferencing that caused a panic.

To fix this, instead of passing a Boolean to look for public or private, we use FrontendType with value Public or Private. This will allow to reduce ambiguity and bugs in the future.

Multiple test files got updated due to this as AppGW resources are named using the listener struct hash. As this struct is now taking an enum instead of bool, it has changed hashes across multiple test files. Some places, it has the changes the order of rules in the array.

Fixes

1532

[cloebig]

Hello,

is the segmentation fault now fixed? And is there new Version for that ? I See only the 1.7.0 from 27 March 2023.