Azure / application-gateway-kubernetes-ingress

This is an ingress controller that can be run on Azure Kubernetes Service (AKS) to allow an Azure Application Gateway to act as the ingress for an AKS cluster.
https://azure.github.io/application-gateway-kubernetes-ingress
MIT License
677 stars 420 forks source link

AGIC Helm Chart support Service Principal Kubernetes Secret #1546

Closed TimDurward closed 4 months ago

TimDurward commented 1 year ago

Is your feature request related to a problem? Please describe. It will be nice to reference an existing secret in Kubernetes, rather than plainly putting the base64 within the values.yaml file. This helps with people that use Git-Ops and utilize controllers like SealedSecrets and store their Secrets in Git.

Describe the solution you'd like

A Kubernetes Secret

apiVersion: v1
kind: Secret
metadata:
  name: azure-credentials
type: Opaque
data:
  credentials.json: <base64-encoded-credentials>

Deploying AGIC referencing the secret

ingress-azure:
  appgw:
    subscriptionId: your-azure-subscription-id
    resourceGroup: your-azure-resource-group
    name: your-application-gateway-name
  armAuth:
    type: servicePrincipal
-   secretJSON: {}
+   existingSecret: azure-credentials