Azure / application-gateway-kubernetes-ingress

This is an ingress controller that can be run on Azure Kubernetes Service (AKS) to allow an Azure Application Gateway to act as the ingress for an AKS cluster.
https://azure.github.io/application-gateway-kubernetes-ingress
MIT License
677 stars 420 forks source link

appgw.prohibitedTargets does not work with wildcard hostname #1548

Closed pguyot closed 1 year ago

pguyot commented 1 year ago

Using a values file with appgw.prohibitedTargets does not work with a wildcard in the hostname.

Typically, the following AzureIngressProhibitedTarget:

apiVersion: "appgw.ingress.k8s.io/v1"
kind: AzureIngressProhibitedTarget
metadata:
  name: prohibit-star.domain.com
spec:
  hostname: "*.domain.com"

cannot be added with the following values:

appgw:
    shared: true
    prohibitedTargets:
    - name: prohibit-star.blueplanner.com
      hostname: "*.domain.com"

The following error is generated:

Error: YAML parse error on ingress-azure/templates/crds.yaml: error converting YAML to JSON: yaml: line 6: did not find expected alphabetic or numeric character
pkerspe commented 8 months ago

@akshaysngupta any chance to add this to the upcoming release 1.7.3? Fix is available for a while now in main but unfortunately not in any release. Would be highly appreciated :-)

pkerspe commented 5 months ago

it has been a while and we now have Release 1.7.4 unfortunately it does still not contain the changes merged to main branch in May 2023 to fix this issue. So I might understand it wrong, but this issue is marked closed even though no release exists that contains the fix.

The fix can be seen in here (Main): https://github.com/Azure/application-gateway-kubernetes-ingress/blob/17967aac7a51828b007bad192bd30e97a974514f/helm/ingress-azure/templates/crds.yaml#L27

But in the current release it is still not fixed (Tag 1.7.4): https://github.com/Azure/application-gateway-kubernetes-ingress/blob/3f62f1aa81317bf729b66a10c812bc349ce76b87/helm/ingress-azure/templates/crds.yaml#L27

Kindly asking to add the fix to the next release!

@pguyot do you have any additional information on a planned integration into a release?

pguyot commented 5 months ago

@pkerspe unfortunately I don't and I also wish this would be released.