Add feature flags for Hub/Spoke resources

Azure / appservice-landing-zone-accelerator

The Azure App Service landing zone accelerator is an open-source collection of architectural guidance and reference implementation to accelerate deployment of Azure App Service at scale.

https://build.microsoft.com/en-US/sessions/58f92fab-3298-444d-b215-6b93219cd5d7?source=sessions

MIT License

207 stars 109 forks source link

Add feature flags for Hub/Spoke resources #153

Open JinLee794 opened 1 year ago

JinLee794 commented 1 year ago

Customers have use-cases that may involve bringing their own resources (for example, an existing hub configuration)

Would like to refactor the bicep/terraform templates to accommodate for optional infrastructure resources being created and give the user set number of options on types of existing resources they can bring in.

JinLee794 commented 1 year ago

bicep template: jumpbox vm should be named to be more descriptive instead of (vm-<app_name>-<env>) as well as the self-hosted agent (instead of just github-<env>)

thomas-tran commented 1 year ago

Could we add the flag whether or not hub is required in the deployment? Customer may only need the spoke vnet and did not want to connect to any hub. Or at least, create a hub placeholder with/without firewall or bastion