Azure / appservice-landing-zone-accelerator

The Azure App Service landing zone accelerator is an open-source collection of architectural guidance and reference implementation to accelerate deployment of Azure App Service at scale.
https://build.microsoft.com/en-US/sessions/58f92fab-3298-444d-b215-6b93219cd5d7?source=sessions
MIT License
200 stars 95 forks source link

fix diagnotics changes #180

Closed thotheod closed 10 months ago

thotheod commented 10 months ago

Description

A recent change (deprecation) in how you configure azure diagnostics settings retention policy for storage account sink, resulted in deployments failing.

In our implementation we use Log Analytics Workspace, not storage account, as sink of the diagnostics settings. However, the implementation of the affected modules is based on the CARML repo (which needs to change as well), was not differentiating based on the sink, and it used a "retention" Policy, which is not valid any more.

more details of the change you can find here:

Type of Change

Please delete options that are not relevant.

Checklist