Azure / arm-deploy

ARM action to deploy an Azure Resource Manager (ARM) template to all the deployment scopes
MIT License
83 stars 39 forks source link

azure/arm-deploy@v1 fails after new release of Azure CLI Version 2.24.1 #48

Closed JaMatus closed 3 years ago

JaMatus commented 3 years ago

Hello šŸ™‚ Since the new release (1. June 2021) of Azure CLI Version 2.24.1, our github actions deployment to azure fails on azure/arm-deploy@v1 with following error:

The process 'C:\Program Files (x86)\Microsoft SDKs\Azure\CLI2\wbin\az.cmd' failed because one or more lines were written to the STDERR stream

Have you experienced similar problem or this is not related in your opinion?

Thanks

iamalexmang commented 3 years ago

Alex, I believe the main reason for picking this action in particular rather than using Az CLI was driven by these two ideas:

Get Outlook for iOShttps://aka.ms/o0ukef


From: Matt Thornton @.> Sent: Thursday, June 17, 2021 7:13:16 PM To: Azure/arm-deploy @.> Cc: Alex Mang @.>; Mention @.> Subject: Re: [Azure/arm-deploy] @.*** fails after new release of Azure CLI Version 2.24.1 (#48)

Also I think all of the errors being reported here about the action reporting success even though the deployment failed are a direct consequence of the workaround that's been applied to main. I believe #50https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Farm-deploy%2Fpull%2F50&data=04%7C01%7Camang%40keyticket.eu%7C45a6b34ea42946f914ff08d931aad188%7Cbeaab1c6c6ce475092dacac20ae5d13a%7C1%7C0%7C637595432007446268%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=2rP%2FZW4%2BqSzQzuP9PDNtuJDCoGN8Q1O20Oed7epYcoo%3D&reserved=0 disabled checking stderr because the CLI was erroneously writing whitespace to stderr, so it doesn't seem surprising that as a consequence of this workaround the action will now succeed even when they are errors.

ā€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Farm-deploy%2Fissues%2F48%23issuecomment-863374028&data=04%7C01%7Camang%40keyticket.eu%7C45a6b34ea42946f914ff08d931aad188%7Cbeaab1c6c6ce475092dacac20ae5d13a%7C1%7C0%7C637595432007446268%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=Q7vhE392onrIdjlc1HNleqmfw6TyCqPDcdQ9Xaon%2BHo%3D&reserved=0, or unsubscribehttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABMBPYJPDNNRBQZMOZKNMZ3TTINJZANCNFSM456PX5SA&data=04%7C01%7Camang%40keyticket.eu%7C45a6b34ea42946f914ff08d931aad188%7Cbeaab1c6c6ce475092dacac20ae5d13a%7C1%7C0%7C637595432007456262%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=99KGGO87qRPVgL8G4F7HHMd1VwcLLerdq29SjU5JsLs%3D&reserved=0.

plzm commented 3 years ago

Thanks @t-dedah - see a workflow run here: https://github.com/plzm/always-on/runs/2850980721?check_suite_focus=true Three steps failed ("Deploy NSG Flow Logs ***") but the run shows as successful.

I have run a variety of ARM templates in this repo, all exhibit the same behavior.

t-dedah commented 3 years ago

@parallo-mattallford @plzm @dico-harigkev We have fixed the main version of action to fail if arm deployment fails.

github-actions[bot] commented 3 years ago

This issue is marked default for generating issues report.

t-dedah commented 3 years ago

Fix for this issue has been released to v1 version.

t-dedah commented 3 years ago

Those who moved to main, please feel free to move back to v1 version.

- uses: azure/arm-deploy@v1

instead of using main

github-actions[bot] commented 3 years ago

This issue is stale because it has been open for 7 days with no activity.

t-dedah commented 3 years ago

Closing this issue as fixed has been deployed.

bishal-pdMSFT commented 3 years ago

A RCA of this issue has been posted here. Please feel free to put your comments.