search

Azure / arm-template-whatif

A repository to track issues related to what-if noise suppression
MIT License
86 stars 13 forks source link

Microsoft.Cdn/profiles/endpoints/customdomains #140

Open shenglol opened 3 years ago

shenglol commented 3 years ago

Describe the noise

Resource type (i.e. Microsoft.Storage/storageAccounts) Microsoft.Cdn/profiles/endpoints/customdomains

apiVersion (i.e. 2019-04-01) 2019-12-31

Client (PowerShell, Azure CLI, or API) PowerShell

Relevant ARM Template code (we only need the resource object for the above resourceType and apiVersion, but if it's easier you can include the entire template

Expected response (i.e. "I expected no noise since the template has not been modified since the resources were deployed) No change.

Current (noisy) response (either include a screenshot of the what-if output, or copy/paste the text)

  ~ Microsoft.Cdn/profiles/thetradedesk-ads-html5-cdn/endpoints/thetradedesk-ads-html5 [2019-12-31]
    - properties.customDomains: [
        0:

          name:                "azhtml5-adsrvr-org"
          properties.hostName: "azhtml5.adsrvr.org"

      ]

  ~ Microsoft.Cdn/profiles/thetradedesk-ads-html5-cdn/endpoints/thetradedesk-ads-html5/customdomains/azhtml5-adsrvr-org [2019-12-31]
    - properties.customHttpsParameters:

        certificateSource:                             "AzureKeyVault"
        certificateSourceParameters.@odata.type:       "#Microsoft.Azure.Cdn.Models.KeyVaultCertificateSourceParameters"
        certificateSourceParameters.deleteRule:        "NoAction"
        certificateSourceParameters.resourceGroupName: "va9-ttd-tls-certs-rg"
        certificateSourceParameters.secretName:        "STARadsrvrorg"
        certificateSourceParameters.secretVersion:     "cb20f743b7f8497ba762bd9fb33fc9d2"
        certificateSourceParameters.subscriptionId:    "001a3882-eb1c-42ac-9edc-5e2872a07783"
        certificateSourceParameters.updateRule:        "NoAction"
        certificateSourceParameters.vaultName:         "va9-TTDImportedCerts-kv"
        minimumTlsVersion:                             "TLS12"
        protocolType:                                  "ServerNameIndication"

Additional context Add any other context about the problem here.

alex-frankel commented 3 years ago

@detienne20 is this w51?

detienne20 commented 3 years ago

w51

alex-frankel commented 3 years ago

This fix should be fully deployed. Please let us know if you are still seeing the issue.

alex-frankel commented 3 years ago

Re-opening as it looks like some of the noise is still present:

  ~ Microsoft.Cdn/profiles/thetradedesk-ads-html5-cdn [2019-12-31]
    - kind: "cdn"

  ~ Microsoft.Cdn/profiles/thetradedesk-ads-html5-cdn/endpoints/thetradedesk-ads-html5 [2019-12-31]
    - properties.customDomains: [
        0:

          name:                "azhtml5-adsrvr-org"
          properties.hostName: "azhtml5.adsrvr.org"

      ]
shenglol commented 3 years ago

The following property is covered by the Swagger round trip validation KPI:

Since it's not fixed by the RP team yet, we'll tag it in our noise reports.

The $.properties.customDomains is not captured by the KPI because our KPI data generator filtered it out due to some pre-defined rules. We have tagged it in our noise reports manually, but we'll also try to fix the KPI data generator so it will be added to the KPI data.

kleky commented 3 years ago

Hi, we're having this same issue too. All of a sudden the what-if is identifying these changes to custom domain, but also to Azure for MySql admin password

 - properties.customHttpsParameters:

        certificateSource:                           "Cdn"
        certificateSourceParameters.@odata.type:     "#Microsoft.Azure.Cdn.Models.CdnCertificateSourceParameters"
        certificateSourceParameters.certificateType: "Dedicated"
        minimumTlsVersion:                           "TLS12"
        protocolType:                                "ServerNameIndication"
~ Microsoft.DBforMySQL/servers/rch*****dev [2017-12-01]
    + properties.administratorLoginPassword: "*******"
    + properties.createMode:                 "Default"
kleky commented 3 years ago

Is this a what-if bug, so when I deploy these changes "shouldn't" be applied, given that nothing has changed since the last deployment?

alex-frankel commented 3 years ago

Hi @kleky - these are what-if noise issues. The properties under properties.customHttpsParameters look like default values. The DBforMySql/servers noise should be filed as a separate issue, but those look like write-only properties that are not tagged as such in the DBforMySql/servers api definition.