Azure / arm-template-whatif

A repository to track issues related to what-if noise suppression
MIT License
85 stars 12 forks source link

what-if noise when using default properties of service bus queues & topics #303

Open Geertvdc opened 1 year ago

Geertvdc commented 1 year ago

Describe the noise

Resource type

apiVersion

2022-10-01-preview also tried 2021-11-01

Client (PowerShell, Azure CLI, or API) AZ CLI

Relevant ARM Template code (we only need the resource object for the above resourceType and apiVersion, but if it's easier you can include the entire template

resource topic 'Microsoft.ServiceBus/namespaces/topics@2022-10-01-preview' = {
  name: 'sbt-topic1'
  parent: servicebus
}

resource queue 'Microsoft.ServiceBus/namespaces/queues@2022-10-01-preview' = {
  name: 'sbq-queue1'
  parent: servicebus
}

Expected response (i.e. "I expected no noise since the template has not been modified since the resources were deployed) I deployed this same resource 2x in a row. I expected it to show no noise.

Current (noisy) response (either include a screenshot of the what-if output, or copy/paste the text)

~ Microsoft.ServiceBus/namespaces/sb-tmp/queues/sbq-queue1 [2022-10-01-preview]
    - properties.autoDeleteOnIdle:                    "P10675199DT2H48M5.4775807S"
    - properties.deadLetteringOnMessageExpiration:    false
    - properties.defaultMessageTimeToLive:            "P10675199DT2H48M5.4775807S"
    - properties.duplicateDetectionHistoryTimeWindow: "PT10M"
    - properties.enablePartitioning:                  false
    - properties.lockDuration:                        "PT1M"
    - properties.maxMessageSizeInKilobytes:           1024
    - properties.maxSizeInMegabytes:                  1024
    - properties.requiresDuplicateDetection:          false

  ~ Microsoft.ServiceBus/namespaces/sb-tmp/topics/sbt-topic1 [2022-10-01-preview]
    - properties.autoDeleteOnIdle:                    "P10675199DT2H48M5.4775807S"
    - properties.defaultMessageTimeToLive:            "P10675199DT2H48M5.4775807S"
    - properties.duplicateDetectionHistoryTimeWindow: "PT10M"
    - properties.enableBatchedOperations:             true
    - properties.enableExpress:                       false
    - properties.enablePartitioning:                  false
    - properties.maxMessageSizeInKilobytes:           1024
    - properties.maxSizeInMegabytes:                  1024
    - properties.supportOrdering:                     true
ponkumarpandian commented 1 year ago

image

There are so many property which are not modify still show as modified removed

andrew-hillier commented 10 months ago

I'm also seeing similar on subscriptions (Microsoft.ServiceBus/namespaces/topics/subscriptions@2022-10-01-preview)

resource subscription 'Microsoft.ServiceBus/namespaces/topics/subscriptions@2022-10-01-preview' = {
  parent: topic
  name: <subscription>
}

Noisy Output:

  ~ Microsoft.ServiceBus/namespaces/<namespace>/topics/<topic>/subscriptions/<subscription> [2022-10-01-preview]
    - properties.autoDeleteOnIdle:                 "P10675199DT2H48M5.4775807S"
    - properties.deadLetteringOnMessageExpiration: false
    - properties.defaultMessageTimeToLive:         "P10675199DT2H48M5.4775807S"
    - properties.enableBatchedOperations:          true
    - properties.isClientAffine:                   false
    - properties.lockDuration:                     "PT1M"
trevonmckay commented 1 month ago

We'd like to setup conditional deployments in our pipeline to reduce deployment time, but this blocks us from achieving that goal.