Azure / arm-template-whatif

A repository to track issues related to what-if noise suppression
MIT License
90 stars 14 forks source link

Microsoft.Automation/automationAccounts and child resources #92

Closed slavizh closed 4 years ago

slavizh commented 4 years ago

Describe the noise

Resource type (i.e. Microsoft.Storage/storageAccounts) Microsoft.Automation/automationAccounts

apiVersion (i.e. 2019-04-01) 2018-06-30

Client (PowerShell, Azure CLI, or API) PowerShell

Relevant ARM Template code (we only need the resource object for the above resourceType and apiVersion, but if it's easier you can include the entire template

Expected response (i.e. "I expected no noise since the template has not been modified since the resources were deployed)

Current (noisy) response (either include a screenshot of the what-if output, or copy/paste the text)


Scope: /subscriptions/<subscribtion ID>/resourceGroups/lz-start-stop-vms-accp-1

  + Microsoft.Automation/automationAccounts/start-stop-vms-lz-1/jobs/7be55d1b-86d4-4c4f-afab-99d79c7b9fae [2018-06-30]

      apiVersion:              "2018-06-30"
      id:                      "/subscriptions/<subscribtion ID>/resourceGroups/lz-start-stop-vms-accp-1/providers/Microsoft.Automation/automationAccounts/start-stop-vms-lz-1/jobs/7be55d1b-86d4-4c4f-afab-99d79c7b9fae"
      location:                "westeurope"
      name:                    "7be55d1b-86d4-4c4f-afab-99d79c7b9fae"
      properties.runbook.name: "Bootstrap_Main"
      type:                    "Microsoft.Automation/automationAccounts/jobs"

  ~ Microsoft.Automation/automationAccounts/start-stop-vms-lz-1 [2018-06-30]
    - properties.RegistrationUrl: "<Automation account registration url>"

  ~ Microsoft.Automation/automationAccounts/start-stop-vms-lz-1/certificates/AzureRunAsCertificate [2018-06-30]
    + properties.base64Value: "<base 64 value of certificate>"

  ~ Microsoft.Automation/automationAccounts/start-stop-vms-lz-1/modules/Az.Accounts [2018-06-30]
    - location: "westeurope"
    + properties:

        contentLink.uri: "https://devopsgallerystorage.blob.core.windows.net/packages/az.accounts.1.6.2.nupkg"

~ Microsoft.Automation/automationAccounts/start-stop-vms-lz-1/modules/Az.Automation [2018-06-30]
    - location: "westeurope"
    + properties:

        contentLink.uri: "https://devopsgallerystorage.blob.core.windows.net/packages/az.automation.1.3.3.nupkg"

  ~ Microsoft.Automation/automationAccounts/start-stop-vms-lz-1/modules/Az.Compute [2018-06-30]
    - location: "westeurope"
    + properties:

        contentLink.uri: "https://devopsgallerystorage.blob.core.windows.net/packages/az.compute.2.6.0.nupkg"

  ~ Microsoft.Automation/automationAccounts/start-stop-vms-lz-1/modules/Az.Resources [2018-06-30]
    - location: "westeurope"
    + properties:

        contentLink.uri: "https://devopsgallerystorage.blob.core.windows.net/packages/az.resources.1.7.0.nupkg"

~ Microsoft.Automation/automationAccounts/start-stop-vms-lz-1/providers/Microsoft.Insights/diagnosticSettings/LogsAndMetricsToLogAnalytics [2017-05-01-preview]
[
      ~ 0:

        - retentionPolicy.enabled: false

      ~ 1:

        - retentionPolicy.enabled: false

      - 2:

          category:                "DscNodeStatus"
          enabled:                 false
          retentionPolicy.days:    0
          retentionPolicy.enabled: false

      ]
[
      ~ 0:

        - retentionPolicy:

            days:    0
            enabled: false

      ]

~ Microsoft.Automation/automationAccounts/start-stop-vms-lz-1/runbooks/Bootstrap_Main [2018-06-30]
    + properties.publishContentLink:

        uri:     "<link to storage account with SAS>"
        version: "2.0.0.0"

  ~ Microsoft.Automation/automationAccounts/start-stop-vms-lz-1/runbooks/ScheduledStartStop_Child [2018-06-30]
    + properties.publishContentLink:

        uri:     "<link to storage account with SAS>"
        version: "2.0.0.0"

  ~ Microsoft.Automation/automationAccounts/start-stop-vms-lz-1/runbooks/ScheduledStartStop_Parent [2018-06-30]
    + properties.publishContentLink:

        uri:     "<link to storage account with SAS>"
        version: "2.0.0.0"

~ Microsoft.Automation/automationAccounts/start-stop-vms-lz-1/variables/External_ExcludeDatesVmTag [2018-06-30]
    + properties.type: "System.String"

  ~ Microsoft.Automation/automationAccounts/start-stop-vms-lz-1/variables/External_ExcludeStartDatesVmTag [2018-06-30]
    + properties.type: "System.String"

  ~ Microsoft.Automation/automationAccounts/start-stop-vms-lz-1/variables/External_ExcludeStartWeekdaysVmTag [2018-06-30]
    + properties.type: "System.String"

  ~ Microsoft.Automation/automationAccounts/start-stop-vms-lz-1/variables/External_ExcludeStopDatesVmTag [2018-06-30]
    + properties.type: "System.String"

  ~ Microsoft.Automation/automationAccounts/start-stop-vms-lz-1/variables/External_ExcludeStopWeekdaysVmTag [2018-06-30]
    + properties.type: "System.String"

  ~ Microsoft.Automation/automationAccounts/start-stop-vms-lz-1/variables/External_ExcludeWeekdaysVmTag [2018-06-30]
    + properties.type: "System.String"

  ~ Microsoft.Automation/automationAccounts/start-stop-vms-lz-1/variables/External_OverwriteStartVmTag [2018-06-30]
    + properties.type: "System.String"

  ~ Microsoft.Automation/automationAccounts/start-stop-vms-lz-1/variables/External_OverwriteStopVmTag [2018-06-30]
    + properties.type: "System.String"

  ~ Microsoft.Automation/automationAccounts/start-stop-vms-lz-1/variables/External_ScheduleRunInterval [2018-06-30]
    + properties.type: "System.Int32"

  ~ Microsoft.Automation/automationAccounts/start-stop-vms-lz-1/variables/External_StartStopVmTag [2018-06-30]
    + properties.type: "System.String"

  ~ Microsoft.Automation/automationAccounts/start-stop-vms-lz-1/variables/Internal_AutomationAccountName [2018-06-30]
    + properties.type: "System.String"

  ~ Microsoft.Automation/automationAccounts/start-stop-vms-lz-1/variables/Internal_AzureSubscriptionId [2018-06-30]
    + properties.type: "System.String"
~ Microsoft.Automation/automationAccounts/start-stop-vms-lz-1/variables/Internal_ResourceGroupName [2018-06-30]
    + properties.type: "System.String"

  ~ Microsoft.Insights/workbooks/151555db-3d9f-50e9-81d5-c6ddcd868160 [2018-06-17-preview]
    - properties.timeModified: "2020-06-19T12:35:24.4464566Z"
    - properties.userId:       "10032000962af628"
    ~ properties.sourceId:     "azure monitor" => "Azure Monitor"

  = Microsoft.Automation/automationAccounts/start-stop-vms-lz-1/connections/AzureRunAsConnection [2018-06-30]

Resource changes: 1 to create, 24 to modify, 2 no change.

Additional context Add any other context about the problem here.

shenglol commented 4 years ago

The noise for Microsoft.Insights/diagnosticSettings is due to the fact that What-If is not able to handle partial PUT for arrays, which is tracked by #62.

I've fixed the other noise. [w33]

alex-frankel commented 4 years ago

The noise fix has been deployed. we will track the other issue with #62