search

Azure / autorest.az

Azure CLI Code Generator
MIT License
22 stars 20 forks source link

20210225 ontag cmdlet #759

Closed changlong-liu closed 3 years ago

qiaozha commented 3 years ago

@changlong-liu Left a few comment, I am wondering should we make positive and negative test configurable?

changlong-liu commented 3 years ago

@changlong-liu Changlong Liu FTE Left a few comment, I am wondering should we make positive and negative test configurable?

yes, we can discuss in CLI bi-weekly meeting whether mock test should be generate by default or on demand.

changlong-liu commented 3 years ago

/azp run

azure-pipelines[bot] commented 3 years ago
Azure Pipelines successfully started running 1 pipeline(s).
qiaozha commented 3 years ago

@changlong-liu I am also curious, Since you are using code template to generate the conftest.py or positive negative tests, Is this possible that the generated code may violate some pylint rules? Do we need to use code format tools to format them just in case ?

changlong-liu commented 3 years ago

@changlong-liu Changlong Liu FTE I am also curious, Since you are using code template to generate the conftest.py or positive negative tests, Is this possible that the generated code may violate some pylint rules? Do we need to use code format tools to format them just in case ?

Hi @qiaozha , don't get pylint issue now. And I didn't use auto-formating on them since:

  1. it will affect inplace-edit in test file
  2. the formatted result looks not as good as current output. (now each param is in one txt line, and the auto-formatting will merge them without particular alignment)
qiaozha commented 3 years ago

@changlong-liu Changlong Liu FTE I am also curious, Since you are using code template to generate the conftest.py or positive negative tests, Is this possible that the generated code may violate some pylint rules? Do we need to use code format tools to format them just in case ?

Hi @qiaozha , don't get pylint issue now. And I didn't use auto-formating on them since:

  1. it will affect inplace-edit in test file
  2. the formatted result looks not as good as current output. (now each param is in one txt line, and the auto-formatting will merge them without particular alignment)

I see