search

Azure / autorest.az

Azure CLI Code Generator
MIT License
22 stars 20 forks source link

Should not label command group as experimental for CLI core #763

Closed jsntcy closed 3 years ago

jsntcy commented 3 years ago

Current codegen will label command group as experimental for CLI core, it's wrong behavior. Below is the current generated code example:

with self.command_group('vm', is_experimental=True):
        pass
changlong-liu commented 3 years ago

discuss detail in meeting

qiaozha commented 3 years ago

remove overall is_experimental=True, for target-mode == 'core' instead of set it in each command group individually.

about default compatible-level value in target-mode == 'core'

  1. don't change the default value for now. instead cli team will provide a list to set each services's default compatible level @jsntcy
  2. Code generator should output some info about which compatible-level is being used right now.
qiaozha commented 3 years ago

@jsntcy pending on cli team to provide the map befween cli modules and track1 and track1 mapping.

changlong-liu commented 3 years ago

Hi @jsntcy , please call us when the mapping is ready

changlong-liu commented 3 years ago

merged