search

Azure / autorest.azure-functions

Code Generation for Azure Functions
MIT License
46 stars 6 forks source link

Difference in generated code between VS code extension and autorest CLI #7

Open balderstonb opened 3 years ago

balderstonb commented 3 years ago

Not sure if this the right place to report this, but when I generated C# from the Azure Functions VS code extension, it set the TargetFramework to netcoreapp2.1 in the csproj, which causes "error CS8370: Feature 'nullable reference types' is not available in C# 7.3. Please use language version 8.0 or greater" on build because of the "#nullable disable" in each .cs file in the Models folder.

When I ran autorest directly (autorest --azure-functions-csharp --input-file:spec.json --output-folder:./generated-azfunctions --version:3.0.6314 --namespace:CovidScreeningNamespace), the TargetFramework was netcoreapp3.1 and it built successfully.

vrdmr commented 3 years ago

Thanks, @balderstonb - autorest.azure-functions-csharp which generates the code only uses dotnet 3.0.

I have added a validation check for VSCode to make sure devs use only dotnet 3.0 for autorest generated apps.

/cc @skylerah