Azure / autorest.csharp

Extension for AutoRest (https://github.com/Azure/autorest) that generates C# code
MIT License
140 stars 160 forks source link

[DPG] [Design Issue]: Determine how to handle global parameters in DPG Client constructors #2106

Open annelo-msft opened 2 years ago

annelo-msft commented 2 years ago

Problem

We have a test case in autorest.csharp, where the client constructors are not generated following the .NET guidelines. This has been described in this issue: https://github.com/azure/autorest.csharp/issues/2055

We need to determine how best to handle global parameters in generated client constructors. Since there are no Data Plane Generated libraries that currently have this case in their OpenAPI specs, we will not block DPG GA on this.

Success Criteria

Redmond team provides a spec indicating how to handle global parameters in generated client constructors.

Once we have determined the design we want for the generated client constructors on clients that have global parameters, we will complete work on #2055.

Note: We have had a number of discussions about this offline, and as time allows, that information will be added to this issue so that it contains the full context.

pshao25 commented 3 months ago

For optional global parameter, we have decided https://github.com/Azure/autorest.csharp/issues/3706#issuecomment-1752374728