search

Azure / autorest.java

Extension for AutoRest (https://github.com/Azure/autorest) that generates Java code
MIT License
33 stars 82 forks source link

mgmt sample generation, not generate `x-ms-original-file` if it's null #2620

Closed XiaofeiCao closed 5 months ago

XiaofeiCao commented 6 months ago

For MPG, currently it's null: https://github.com/XiaofeiCao/azure-sdk-for-java/commit/07f104a384d0c319b0ac55cfba52a151f733d117#diff-a0cb00f904306c2eed06d46706e2584c0dac9985fea092a1b854d13c0973734a

This may lead to weird behavior for sample collection: https://github.com/weidongxu-microsoft/azure-rest-api-specs-examples-automation/blob/main/java/main.py#L230 (java_example.target_dir will be empty string "", java_example.target_filename will be "null")

XiaofeiCao commented 5 months ago

Should already be fixed in https://github.com/Azure/autorest.java/pull/2640