Closed alzimmermsft closed 1 month ago
Do we need to remove these dependencies and duplicate a lot of code that can get outdated if the core libraries change? The generated library still needs released core libraries anyway. Since core ships to Maven Central every month and ships to dev feed almost daily, using the dependency shouldn't be a blocker on the code generator.
Do we need to remove these dependencies and duplicate a lot of code that can get outdated if the core libraries change? The generated library still needs released core libraries anyway. Since core ships to Maven Central every month and ships to dev feed almost daily, using the dependency shouldn't be a blocker on the code generator.
I agree this ends up duplicating code from azure-core
but there are some reasons behind that to me.
azure-core
. In recent months though, we've began working and developing generic-core
which has some drastically different designs. This is pushing the generators into a spot where if these diverge too deeply we'll need to jump through some complex logic to handle that.azure-core
are tied deeply into Swagger / TypeSpec outputs. To me, it'd be better for the generator to own those types and map them appropriately to azure-core
/ generic-core
/ HttpHeaderName.fromString
which will return the same instance as the constant).azure-core
, and related libraries. I don't think shipping cadence one way or another is a big factor for the generator.All that said, I'll hold this PR in an unmerged state so we can discuss this further.
Hi @alzimmermsft. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.
Hi @alzimmermsft. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.
Removes dependencies on
azure-core
,generic-core
, and related SDKs to allow for more flexibility in working with non-shipped implementation of those libraries.