Azure / autorest.java

Extension for AutoRest (https://github.com/Azure/autorest) that generates Java code
MIT License
33 stars 80 forks source link

Remove direct dependencies to Azure SDKs #2626

Closed alzimmermsft closed 1 month ago

alzimmermsft commented 4 months ago

Removes dependencies on azure-core, generic-core, and related SDKs to allow for more flexibility in working with non-shipped implementation of those libraries.

srnagar commented 4 months ago

Do we need to remove these dependencies and duplicate a lot of code that can get outdated if the core libraries change? The generated library still needs released core libraries anyway. Since core ships to Maven Central every month and ships to dev feed almost daily, using the dependency shouldn't be a blocker on the code generator.

alzimmermsft commented 4 months ago

Do we need to remove these dependencies and duplicate a lot of code that can get outdated if the core libraries change? The generated library still needs released core libraries anyway. Since core ships to Maven Central every month and ships to dev feed almost daily, using the dependency shouldn't be a blocker on the code generator.

I agree this ends up duplicating code from azure-core but there are some reasons behind that to me.

All that said, I'll hold this PR in an unmerged state so we can discuss this further.

microsoft-github-policy-service[bot] commented 2 months ago

Hi @alzimmermsft. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

microsoft-github-policy-service[bot] commented 1 month ago

Hi @alzimmermsft. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.