search

Azure / autorest.java

Extension for AutoRest (https://github.com/Azure/autorest) that generates Java code
MIT License
32 stars 80 forks source link

tsp, try remove default on host #2762

Closed weidongxu-microsoft closed 1 month ago

weidongxu-microsoft commented 1 month ago

not able to handle here https://github.com/Azure/autorest.java/pull/2760

guess we could just remote it (anyway we don't need client default).

haolingdong-msft commented 1 month ago

I don't quite get why do we remove client default value?

weidongxu-microsoft commented 1 month ago

"next" version deprecated this "default". https://github.com/Azure/autorest.java/pull/2760 (and changed to a defaultValue that we cannot use in this version)

Also this wasn't suppose to be "client default".

    @doc("second-level domain, use httpbin")
    domain?: string = "httpbin",

    @doc("top-level domain, use org")
    tld?: string = "org",

It supposed to be "server default" (though probably not meaningful if this is path).

weidongxu-microsoft commented 1 month ago

/check-enforcer override

weidongxu-microsoft commented 1 month ago

I will put the compatibility of "next" for nightly build to another PR.

We know there is break in "next"...