Azure / autorest.powershell

AutoRest PowerShell Generator
MIT License
112 stars 78 forks source link

Test Recording files getting deleted after recording tests for ContainerInstance module #1111

Closed diyellap closed 1 year ago

diyellap commented 1 year ago

Description

Hi,

For ContainerInstance module, I created my branch on top of 'generation' branch, generated code from new swagger, added new tests and ran all tests with the command: pwsh test-module.ps1 -record. All tests ran fine but all previous recording files under test/ folder were deleted, and no new recording files were added. Can you please let me know how to resolve this issue?

    deleted:    Add-AzContainerInstanceOutput.Recording.json
    deleted:    Get-AzContainerGroup.Recording.json
    deleted:    Get-AzContainerInstanceCachedImage.Recording.json
    deleted:    Get-AzContainerInstanceCapability.Recording.json
    deleted:    Get-AzContainerInstanceLog.Recording.json
    deleted:    Get-AzContainerInstanceUsage.Recording.json
    deleted:    Invoke-AzContainerInstanceCommand.Recording.json
    deleted:    New-AzContainerGroup.Recording.json
    deleted:    Remove-AzContainerGroup.Recording.json
    deleted:    Restart-AzContainerGroup.Recording.json
    deleted:    Start-AzContainerGroup.Recording.json
    deleted:    Stop-AzContainerGroup.Recording.json
    deleted:    Update-AzContainerGroup.Recording.json
isra-fel commented 1 year ago

I'll move this issue to autorest.powershell repo

isra-fel commented 1 year ago

Hi @diyellap can you push your updates and share your branch?

dolauli commented 1 year ago

@diyellap Cleaning the recording files are expected behavior when you re-record tests. But not sure why there are no new recording files generated. Can you be sure that you run the record test successfully.

diyellap commented 1 year ago

Yes, all tests ran fine but no recording file was generated: Tests completed in 1284.34s Tests Passed: 58, Failed: 0, Skipped: 7,

Here's my branch: https://github.com/diyellap/azure-powershell/tree/spot-confidential-containers . I pushed my updates here along with the newly added test files. It was generated on top of generation branch not main branch.

diyellap commented 1 year ago

@.**@.> @@.> @FNU @.>

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows

From: @.> Sent: Friday, February 10, 2023 2:00 AM To: @.> Cc: Divya Bharadwaj @.>; @.> Subject: Re: [Azure/autorest.powershell] Test Recording files getting deleted after recording tests for ContainerInstance module (Issue #1111)

@diyellaphttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdiyellap&data=05%7C01%7Cdiyellap%40microsoft.com%7Ce24517f06de148a2462108db0b4d9f56%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638116200239278463%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=FzKnBsJYGOEtd53kWbXx3Gl5BmG3Uj%2BP5dk2nXW4Cuk%3D&reserved=0 Clean the recording files are expected when you re-record tests. But not sure why there are no new recording files generated. Can you be sure that you run the record test successfully.

— Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fautorest.powershell%2Fissues%2F1111%23issuecomment-1425544720&data=05%7C01%7Cdiyellap%40microsoft.com%7Ce24517f06de148a2462108db0b4d9f56%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638116200239278463%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=uex4brLlGo%2BjtGQ4VdZAJqVgjJ9obmqvHq2u5PwuvmM%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAF3U6ZJLVR6B33PZQIW7323WWYGTLANCNFSM6AAAAAAUXM5U5A&data=05%7C01%7Cdiyellap%40microsoft.com%7Ce24517f06de148a2462108db0b4d9f56%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C638116200239278463%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=yi4FUfC%2B2Aqoqv%2Fd1m6g2Otfgxi%2FZabcT9wNkXDBlno%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

dolauli commented 1 year ago

Closed it since the issue can not be reproduced after the developer created a new branch from the generation branch.