deserialization issue following moving to new requests and responses

Azure / autorest.python

Extension for AutoRest (https://github.com/Azure/autorest) that generates Python code

MIT License

76 stars 54 forks source link

deserialization issue following moving to new requests and responses #2647

Closed iscai-msft closed 2 weeks ago

iscai-msft commented 2 weeks ago

Search is running into issues deseiralizing following our pr moving over to new requests and responses. The issue isn't the new requests and responses, the issue is that we are now only deserializing with pipeline_response.http_response instead of pipeline_response. Roll back part of this change, because we don't want to modify core behavior. This is in search

cc @xiangyan99

msyyc commented 2 weeks ago

I infer search SDK is generated with cmd autorest D:\dev\azure-rest-api-specs\specification\search\data-plane\Azure.Search\readme.md --python --python-sdks-folder=D:\dev\azure-sdk-for-python\sdk --use=@autorest/python@6.14.0 --use=@autorest/modelerfour@4.27.0 --version=3.10.2 --version-tolerant=False --tag=package-2021-04-searchindex-preview

msyyc commented 2 weeks ago

We have test cover this scenario https://github.com/Azure/autorest.python/blob/029547c6f97bdb153cecc495a14ff3aaa233a188/packages/autorest.python/test/vanilla/legacy/Expected/AcceptanceTests/BodyInteger/bodyinteger/operations/_int_operations_operations.py#L401 and I can't reproduce the deserialization issue. Could you provide more details about the issue? @iscai-msft @xiangyan99