search

Azure / autorest.typescript

Extension for AutoRest (https://github.com/Azure/autorest) that generates TypeScript code. The transpiled javascript code is isomorphic. It can be run in browser and in node.js environment.
MIT License
178 stars 75 forks source link

[Paging] Expose nextLink/Continuation Token as part of the returned items #1326

Closed deyaaeldeen closed 2 years ago

deyaaeldeen commented 2 years ago

Some customers need access to it to suspend and resume iterating. See https://github.com/Azure/azure-sdk-for-js/issues/20380#issuecomment-1051410026

qiaozha commented 2 years ago

@deyaaeldeen are you going to fix this issue soon ? as this is blocking customer migrate from track1 to track2 https://github.com/Azure/azure-sdk-for-js/issues/17499#issuecomment-1050548699 Could you take this as a higher priority ?

deyaaeldeen commented 2 years ago

@qiaozha I will defer to @sarangan12 and the code gen crew to address this issue but I agree it should take high priority. Also, https://github.com/Azure/autorest.typescript/issues/1199 is related and is equally if not more important since it enables customers to get pages from specific continuation tokens.

I am happy to offer guidance and to participate in any design discussions for it.

sarangan12 commented 2 years ago

@deyaaeldeen Thanks for the response (ofcourse I need your input in design :-)) . @qiaozha As this is blocking customer, I will take this as high priority and start working on this.

qiaozha commented 2 years ago

@sarangan12 is there any updates for this ? Thanks

sarangan12 commented 2 years ago

The Prototype code is available at https://github.com/Azure/azure-sdk-for-js/pull/20809/files. But, I can focus on this and test it and deploy it only after the completion of storage task that I am working on. I will soon start implementing the solution. Once I am done, I will update this issue.

Regards Sarangan Rajamanickam

Sent from Outlookhttp://aka.ms/weboutlook

From: Qiaoqiao Zhang @.> Sent: Wednesday, March 23, 2022 12:19 AM To: Azure/autorest.typescript @.> Cc: Sarangan Rajamanickam @.>; Mention @.> Subject: Re: [Azure/autorest.typescript] [Paging] Expose nextLink/Continuation Token as part of the returned items (Issue #1326)

@sarangan12https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsarangan12&data=04%7C01%7Csarajama%40microsoft.com%7Ced1cc20242a04771f33d08da0c9d70cb%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637836167596040328%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=HhhlDJMxhcIjfOGRjxIwuLAtRv0CrDx%2BHUDJ5QQGCks%3D&reserved=0 is there any updates for this ? Thanks

— Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fautorest.typescript%2Fissues%2F1326%23issuecomment-1076004064&data=04%7C01%7Csarajama%40microsoft.com%7Ced1cc20242a04771f33d08da0c9d70cb%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637836167596040328%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=yXifIezred6GdrwUlTHx2LXHibeRZA9UOeJk62p%2FdwM%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAETCWAES6N3U26WTRSY4ITVBLAXJANCNFSM5PLWAMFQ&data=04%7C01%7Csarajama%40microsoft.com%7Ced1cc20242a04771f33d08da0c9d70cb%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637836167596040328%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=vDSPLhJgz1SaE02g374Z3InjOCmMrd1bvzcALCcW9IU%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

qiaozha commented 2 years ago

@sarangan12 do you need me to review the prototype PR ? or is the design still in discussion ?

sarangan12 commented 2 years ago

@qiaozha The coding for the generator is still in progress. The scenarios are complicated and I am new to this paging operation. So, it is taking more time (This is the third day I am working on it) So, any help you could provide in that area if you have time would be appreciated,

Alternatively, you could test the change in any of the SDKs and confirm the code changes will work

qiaozha commented 2 years ago

@sarangan12 any updates with the coding change in the code generator ? I am currently working on adding back the sample generation because of audit fix don't have much time to take a look at this feature. Thanks

MRayermannMSFT commented 2 years ago

Sad to see this hasn't been getting attention. 😐

xirzec commented 2 years ago

@MRayermannMSFT just merged this, let me know if you have any feedback or issues with using it.