search

Azure / autorest.typescript

Extension for AutoRest (https://github.com/Azure/autorest) that generates TypeScript code. The transpiled javascript code is isomorphic. It can be run in browser and in node.js environment.
MIT License
179 stars 75 forks source link

Revisit the pipeline property in classical client #2087

Open qiaozha opened 1 year ago

qiaozha commented 1 year ago

Currently, we have a property called pipeline to allow customers modify the policies in the core-rest-pipeline as added by https://github.com/Azure/autorest.typescript/pull/2041, but as we are having a hierarchy client now, it's very likely we will have a hierarchy layer called pipeline, which is very common word for resources. This will cause conflicts to the classical layer. See comments here https://github.com/Azure/autorest.typescript/pull/2080#discussion_r1372466048. We need to figure out a better way to allow customers to customize the pipeline policies.

Note: this should also be an issue in the current mgmt plane, but as we have a linter rule says that operation group have to be plural nourns like Pipelines, see the example for datafactory https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/datafactory/arm-datafactory/src/dataFactoryManagementClient.ts#L163. But we don't have that kind of rule, especially in the context of non-branding.

qiaozha commented 1 year ago

In current HLC, we will rename pipelineOperations if there's conflict.

qiaozha commented 1 year ago

Maybe we could consider this from non-breaking perspective ? @joheredi how do you think ?