skip lint script and format script for mgmt package with modular generation

Azure / autorest.typescript

Extension for AutoRest (https://github.com/Azure/autorest) that generates TypeScript code. The transpiled javascript code is isomorphic. It can be run in browser and in node.js environment.

MIT License

177 stars 74 forks source link

skip lint script and format script for mgmt package with modular generation #2649

Open kazrael2119 opened 3 weeks ago

kazrael2119 commented 3 weeks ago

Shall we update the lint script and the format script as echo skipped for mgmt package with modular generation?

qiaozha commented 2 weeks ago

See https://dev.azure.com/azure-sdk/public/_build/results?buildId=3936831&view=logs&j=b70e5e73-bbb6-5567-0939-8415943fadb9&t=70ccc7c9-8d04-5255-456e-9568fe142bcd for more error details if we enable the check.

qiaozha commented 2 weeks ago

If we choose to skip it, we will probably need to skip it for both data plane and mgmt plane as Modular will be used in data plane in the future as well.

qiaozha commented 2 weeks ago

Comments from @joheredi

[ ] Missing return type on function - We should fix
[ ] 'p' is already declared in the upper scope on line - Not sure where this happen need to look the code
[ ] prefixes. I think I will fix this in my current PR, I'm removing the and tracking internal files differently
[ ] ts-doc issues - We should fix
[ ] Don't use Function as a type - I think we'll have to ignore this
[ ] the file does not have a correct copyright header - We should fix
[ ] 'item' is never reassigned. Use 'const' instead - We should fix