search

Azure / autorest.typescript

Extension for AutoRest (https://github.com/Azure/autorest) that generates TypeScript code. The transpiled javascript code is isomorphic. It can be run in browser and in node.js environment.
MIT License
179 stars 75 forks source link

Unbranded CodeGen should generate paging operation with Azure Style #2932

Open lirenhe opened 1 week ago

lirenhe commented 1 week ago

TypeSpec already includes the support of Paging operation for unbranded: https://typespec.io/docs/standard-library/pagination/

Based on the current agreement, with @list, @pageItems and @nextLink, we could generate the paging operation similar with Azure style. Please also ensure related models for paging are added into unbranded core.

MaryGao commented 12 hours ago

@lirenhe Generating azure-style paging interface should be minor work in unbranded area, but what I may concern is if we don't consider the whole typespec paging, but only scope to todo case, there may exist breakings in future we have more paging cases. Is this pontential breaking a concern here?

lirenhe commented 11 hours ago

@lirenhe Generating azure-style paging interface should be minor work in unbranded area, but what I may concern is if we don't consider the whole typespec paging, but only scope to todo case, there may exist breakings in future we have more paging cases. Is this pontential breaking a concern here?

I suggest you discuss with JS architect about this.
The unbranded CodeGen will remain in preview even in next March, so I am not too worried about the potential breaking change today.