Azure / avdaccelerator

AVD Accelerator deployment automation to simplify the setup of AVD (Azure Virtual Desktop) based on best practices
MIT License
326 stars 207 forks source link

AVD Landing Zone Accelerator Deployment error - storage-fslogix #471

Closed jmatveyev closed 1 year ago

jmatveyev commented 1 year ago

"Diagnostic settings does not support retention for new diagnostic settings."

need to know which specific lines need to be set to false to bypass this.

iScreen Shoter - Microsoft Teams - 230907164205

danycontre commented 1 year ago

@jmatveyev thanks for reporting the issue, we are checking it.

Are you using existing or new log analytics workspace?

@moisesjgomez

jmatveyev commented 1 year ago

Existing workspace

jmatveyev commented 1 year ago

I can also tell you that Setting the following lines in the template to "false" did not solve the problem. There is more to it.

Line 41451, 41464, 37197, 37210

j-d-harvey commented 1 year ago

Looks like I submitted a duplicate issue. Ran into this myself recently and it is due to a change a couple of weeks ago:

https://github.com/Azure/ResourceModules/issues/3572

To fix under Microsoft.Insights/diagnosticSettings in the Logs section set:

retentionPolicy: {
  enabled: false
  days: 0
}

Note this would need to be done for any resources the diagnostics get enabled on with Log Analytics as destination

danycontre commented 1 year ago

@j-d-harvey thanks for the testing and insights we are checking diagnostic settings on all resources to apply a fix.

We will be closing your issue as we are working on the same topic on this one.

jmatveyev commented 1 year ago

Hi, just following up for a status update?

DenisBalan commented 1 year ago

Any ETA? as we are affected as well. Thx

moisesjgomez commented 1 year ago

@jmatveyev @DenisBalan @danycontre The issue stems from diagnostic settings retention settings being deprecated, so they have been removed from the Accelerator, fixing the issue and allowing deployments to go through again. Please test and let us know if you find any other issues. Thanks.