Closed yahanda closed 4 months ago
@yahanda thanks for your contribution, we will review it and update you.
@jensheerin will ping you to make sure Bicep and TF AzFW code is aligned.
cc: @moisesjgomez
@yahanda please sync your fork/branch with Azure/main.
@danycontre I just synced with the latest changes into my branch. Thanks.
@yahanda Thank you for your contribution! Reviewing the PR and will let you know of any further updates
Hi @moisesjgomez, I have updated it based on your advice. I would like to ask you to review my branch.
Testing evidence
1) deploy Fw to Hub vnet
2) deploy Fw to another existing vNet
Hi @danycontre, this doesn't seem to be merged yet. Can it be reopened?
CC: @swathibhat1
Overview/Summary
https://learn.microsoft.com/en-us/azure/firewall/protect-azure-virtual-desktop?tabs=azure the need for inspecting and filtering egress traffic from AVD, but isn't this function typically a part of platform landing zone and the 'network hub', so it is deployed as part of platform foundation (different subscriptions), rather than AVD landing zone
This PR fixes/adds/changes/removes
Breaking Changes
Testing Evidence
Tested from the linke here: https://portal.azure.com/#blade/Microsoft_Azure_CreateUIDef/CustomDeploymentBlade/uri/https%3A%2F%2Fraw.githubusercontent.com%2Fyahanda%2Favdaccelerator-bicep-edits%2Fmain%2Fworkload%2Farm%2Fdeploy-baseline.json/uiFormDefinitionUri/https%3A%2F%2Fraw.githubusercontent.com%2Fyahanda%2Favdaccelerator-bicep-edits%2Fmain%2Fworkload%2Fportal-ui%2Fportal-ui-baseline.json
The portal displays a new firewall option.![image](https://github.com/Azure/avdaccelerator/assets/58975407/c22db455-927d-4753-92ac-488c2f7a27e2)
The deployment was successful.![image](https://github.com/Azure/avdaccelerator/assets/58975407/d7f56065-09a7-4b62-ad6f-88683e464cef)
Firewall and related resources successfully deployed.
![image](https://github.com/Azure/avdaccelerator/assets/58975407/2c1b6a9c-5d21-4d97-a429-ed5d73260b85)
As part of this Pull Request I have
.bicep
file/s I am adding/editing are using the latest API version possiblemain
branch