Azure / avdaccelerator

AVD Accelerator deployment automation to simplify the setup of AVD (Azure Virtual Desktop) based on best practices
MIT License
334 stars 212 forks source link

Support for complex AD domain join passwords #522

Closed SvenAelterman closed 11 months ago

SvenAelterman commented 11 months ago

Overview/Summary

Wrap domain join password in " in the script arguments and escape any " that might be in the password.

This PR fixes/adds/changes/removes

  1. Fixes #515

Breaking Changes

N/A

Testing Evidence

Successful deployment of FSLogix and MSIX storage accounts with AD domain join using a complex password containing |, @, \, :, and many more.

As part of this Pull Request I have

SvenAelterman commented 11 months ago

@moisesjgomez I discovered that this solution is still incomplete too. Single quotes in the password (') still causes an issue with the storage account AD domain join scripts.

moisesjgomez commented 11 months ago

@SvenAelterman Got it thanks for the update. I've merged into a new feature branch for testing. If you are able to add this component please raise another PR. Thank you.