search

Azure / avdaccelerator

AVD Accelerator deployment automation to simplify the setup of AVD (Azure Virtual Desktop) based on best practices
MIT License
331 stars 210 forks source link

Standard storage account is not enabled for large file shares #533

Closed SvenAelterman closed 11 months ago

SvenAelterman commented 11 months ago

What happened? Provide a clear and concise description of the bug, including deployment details.

Deploying for FSLogix and/or MSIX App Attach with a standard storage account creates a storage account that is not enabled for large file shares, thereby reducing performance (IOPS especially, by 50%).

Please provide the correlation id associated with your error or bug.

No response

What was the expected outcome?

Standard storage accounts should be configured for large file share support if using LRS or ZRS.

Relevant log output

No response

SvenAelterman commented 11 months ago

Performance test with DiskSpd indicates the performance impact is significant:

Before large file shares enabled:

Total IO
thread |       bytes     |     I/Os     |    MiB/s   |  I/O per s |  file
------------------------------------------------------------------------------
     0 |       244514816 |         3731 |       3.89 |      62.18 | \\stfsladj1dqib.file.core.windows.net\fslogix-pc-adj1-dev-use-001\test.dat (1MiB)
     1 |       251789312 |         3842 |       4.00 |      64.03 | \\stfsladj1dqib.file.core.windows.net\fslogix-pc-adj1-dev-use-001\test.dat (1MiB)
     2 |       235732992 |         3597 |       3.75 |      59.95 | \\stfsladj1dqib.file.core.windows.net\fslogix-pc-adj1-dev-use-001\test.dat (1MiB)
     3 |       242417664 |         3699 |       3.85 |      61.65 | \\stfsladj1dqib.file.core.windows.net\fslogix-pc-adj1-dev-use-001\test.dat (1MiB)
     4 |       236060672 |         3602 |       3.75 |      60.03 | \\stfsladj1dqib.file.core.windows.net\fslogix-pc-adj1-dev-use-001\test.dat (1MiB)
     5 |       242155520 |         3695 |       3.85 |      61.58 | \\stfsladj1dqib.file.core.windows.net\fslogix-pc-adj1-dev-use-001\test.dat (1MiB)
     6 |       242417664 |         3699 |       3.85 |      61.65 | \\stfsladj1dqib.file.core.windows.net\fslogix-pc-adj1-dev-use-001\test.dat (1MiB)
     7 |       240648192 |         3672 |       3.82 |      61.20 | \\stfsladj1dqib.file.core.windows.net\fslogix-pc-adj1-dev-use-001\test.dat (1MiB)
     8 |       241565696 |         3686 |       3.84 |      61.43 | \\stfsladj1dqib.file.core.windows.net\fslogix-pc-adj1-dev-use-001\test.dat (1MiB)
     9 |       242221056 |         3696 |       3.85 |      61.60 | \\stfsladj1dqib.file.core.windows.net\fslogix-pc-adj1-dev-use-001\test.dat (1MiB)
    10 |       240386048 |         3668 |       3.82 |      61.13 | \\stfsladj1dqib.file.core.windows.net\fslogix-pc-adj1-dev-use-001\test.dat (1MiB)
    11 |       235143168 |         3588 |       3.74 |      59.80 | \\stfsladj1dqib.file.core.windows.net\fslogix-pc-adj1-dev-use-001\test.dat (1MiB)
    12 |       238813184 |         3644 |       3.80 |      60.73 | \\stfsladj1dqib.file.core.windows.net\fslogix-pc-adj1-dev-use-001\test.dat (1MiB)
    13 |       238026752 |         3632 |       3.78 |      60.53 | \\stfsladj1dqib.file.core.windows.net\fslogix-pc-adj1-dev-use-001\test.dat (1MiB)
    14 |       245891072 |         3752 |       3.91 |      62.53 | \\stfsladj1dqib.file.core.windows.net\fslogix-pc-adj1-dev-use-001\test.dat (1MiB)
    15 |       235929600 |         3600 |       3.75 |      60.00 | \\stfsladj1dqib.file.core.windows.net\fslogix-pc-adj1-dev-use-001\test.dat (1MiB)
------------------------------------------------------------------------------
total:        3853713408 |        58803 |      61.25 |     980.05

After:

Total IO
thread |       bytes     |     I/Os     |    MiB/s   |  I/O per s |  file
------------------------------------------------------------------------------
     0 |       466550784 |         7119 |       7.41 |     118.62 | \\stfsladj1dqib.file.core.windows.net\fslogix-pc-adj1-dev-use-001\test.dat (1MiB)
     1 |       475201536 |         7251 |       7.55 |     120.82 | \\stfsladj1dqib.file.core.windows.net\fslogix-pc-adj1-dev-use-001\test.dat (1MiB)
     2 |       465829888 |         7108 |       7.40 |     118.44 | \\stfsladj1dqib.file.core.windows.net\fslogix-pc-adj1-dev-use-001\test.dat (1MiB)
     3 |       473956352 |         7232 |       7.53 |     120.50 | \\stfsladj1dqib.file.core.windows.net\fslogix-pc-adj1-dev-use-001\test.dat (1MiB)
     4 |       469565440 |         7165 |       7.46 |     119.39 | \\stfsladj1dqib.file.core.windows.net\fslogix-pc-adj1-dev-use-001\test.dat (1MiB)
     5 |       474284032 |         7237 |       7.54 |     120.59 | \\stfsladj1dqib.file.core.windows.net\fslogix-pc-adj1-dev-use-001\test.dat (1MiB)
     6 |       474218496 |         7236 |       7.54 |     120.57 | \\stfsladj1dqib.file.core.windows.net\fslogix-pc-adj1-dev-use-001\test.dat (1MiB)
     7 |       474808320 |         7245 |       7.54 |     120.72 | \\stfsladj1dqib.file.core.windows.net\fslogix-pc-adj1-dev-use-001\test.dat (1MiB)
     8 |       465108992 |         7097 |       7.39 |     118.25 | \\stfsladj1dqib.file.core.windows.net\fslogix-pc-adj1-dev-use-001\test.dat (1MiB)
     9 |       467402752 |         7132 |       7.43 |     118.84 | \\stfsladj1dqib.file.core.windows.net\fslogix-pc-adj1-dev-use-001\test.dat (1MiB)
    10 |       464977920 |         7095 |       7.39 |     118.22 | \\stfsladj1dqib.file.core.windows.net\fslogix-pc-adj1-dev-use-001\test.dat (1MiB)
    11 |       476905472 |         7277 |       7.58 |     121.25 | \\stfsladj1dqib.file.core.windows.net\fslogix-pc-adj1-dev-use-001\test.dat (1MiB)
    12 |       467468288 |         7133 |       7.43 |     118.85 | \\stfsladj1dqib.file.core.windows.net\fslogix-pc-adj1-dev-use-001\test.dat (1MiB)
    13 |       476512256 |         7271 |       7.57 |     121.15 | \\stfsladj1dqib.file.core.windows.net\fslogix-pc-adj1-dev-use-001\test.dat (1MiB)
    14 |       468123648 |         7143 |       7.44 |     119.02 | \\stfsladj1dqib.file.core.windows.net\fslogix-pc-adj1-dev-use-001\test.dat (1MiB)
    15 |       470876160 |         7185 |       7.48 |     119.72 | \\stfsladj1dqib.file.core.windows.net\fslogix-pc-adj1-dev-use-001\test.dat (1MiB)
------------------------------------------------------------------------------
total:        7531790336 |       114926 |     119.68 |    1914.94
danycontre commented 11 months ago

@SvenAelterman great catch, working on fix.

danycontre commented 11 months ago

@SvenAelterman code updated and merged into main to enable large share files on standard storage accounts.

PR: https://github.com/Azure/avdaccelerator/pull/534

cc: @swathibhat1 please help us with the ADO tracking item. cc: @moisesjgomez