Azure / avdaccelerator

AVD Accelerator deployment automation to simplify the setup of AVD (Azure Virtual Desktop) based on best practices
MIT License
331 stars 210 forks source link

Updated template to include Private DNS zones for Azure China #547

Closed Poven795909 closed 9 months ago

Poven795909 commented 10 months ago

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

  1. Updates the Info box for Azure Private DNS to include DNS zones for Files and Key Vault.
  2. Updates the deploy-baseline.json to include condition to check if Cloud Env is Azure China and select the appropriate DNS zones.

Breaking Changes

  1. Updates the " Deploy to Azure " button to include one for Azure China and points the Raw file to my fork. [ SHOULD NOT BE MERGED, ONLY FOR REVIEW ]

Testing Evidence

Currently not working , raising this PR only for Review

As part of this Pull Request I have

danycontre commented 9 months ago

@swathibhat1 pending before we merge: