Azure / avdaccelerator

AVD Accelerator deployment automation to simplify the setup of AVD (Azure Virtual Desktop) based on best practices
MIT License
308 stars 201 forks source link

Microsoft Entra ID name update #560

Closed danycontre closed 6 months ago

danycontre commented 6 months ago

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

  1. Updating Azure AD to Microsoft Entra ID
  2. Updating AAD to EntraID
  3. Updating Azure AD Domain Services to Microsoft Entra Domain Services

Breaking Changes

  1. Replace me
  2. Replace me

Testing Evidence

Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

danycontre commented 6 months ago

Just a quick observation, for the CARML modules, unless you've done other editing in the modules to make them custom, I'd say revert those specific changes and let this be an "upstream" problem that is presumably fixed with a future release of their modules. Just adjust your own code, not their modules. Future of CARML is weird anyhow with AVM coming up -- but that's a whole other topic :)

Agree, we will be updating CARML modules to AVM soon, but to your point, yes, we made local edits to the CARML modules, so they work in our use case.

danycontre commented 6 months ago

Updated code merged.

cc: @moisesjgomez @ckittel @swathibhat1