Scaling plan creation failing [fixed]

[ripom]

Overview/Summary

There was a bug in the code that stopped the scaling plan from being created. It was caused by the role assignment not giving the correct role. This resulted in a permission error when creating the scaling plan. I solved the bug by changing the application_id to object_id, as the terraform documentation suggests.

This PR fixes/adds/changes/removes

1. I have fixed the error in the 4 scenarios in the greenfield folder

Breaking Changes

1. Fix the error in the role assignment using object_id instead of application_id

Testing Evidence

I have personally tested only the ADDS scenario, that make me confident the scaling plan creation is working as expected as a consequence of right role assignment fixed.

As part of this Pull Request I have

• [ ] Read the Contribution Guide and ensured this PR is compliant with the guide
• [ ] Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
• [ ] Checked for duplicate Pull Requests
• [ ] Associated it with relevant GitHub Issues
• [ ] (AVD LZA Team Only) Associated it with relevant ADO Items
• [ ] Ensured my code/branch is up-to-date with the latest changes in the main branch
• [ ] Performed testing and provided evidence.
• [ ] Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Docs etc.)

[danycontre]

@ripom thanks for your contribution.

@jensheerin @sihbher please you help checking.