search

Azure / avdaccelerator

AVD Accelerator deployment automation to simplify the setup of AVD (Azure Virtual Desktop) based on best practices
MIT License
305 stars 198 forks source link

azurerm_storage_share.FSShare created for FSLogix is unused #581

Closed mloskot closed 4 months ago

mloskot commented 5 months ago

Let us know the feedback or general question

In the Terraform of the several scenarios, there is this Azure Storage Account and Azure File share created, presumably, for use as container for FSLogix profiles on AVD host VM-s:

https://github.com/Azure/avdaccelerator/blob/c6e13867711a44443256505d8dad50ca79a267ea/workload/terraform/greenfield/AADDSscenario/afstorage.tf#L25-L28

https://github.com/Azure/avdaccelerator/blob/c6e13867711a44443256505d8dad50ca79a267ea/workload/terraform/greenfield/ADDSscenario/afstorage.tf#L25-L28

https://github.com/Azure/avdaccelerator/blob/c6e13867711a44443256505d8dad50ca79a267ea/workload/terraform/greenfield/AADscenario/afstorage.tf#L34-L37

https://github.com/Azure/avdaccelerator/blob/c6e13867711a44443256505d8dad50ca79a267ea/workload/terraform/greenfield/AADDSscenario/afstorage.tf#L25-L28

But, that azurerm_storage_share.FSShare resource is not referenced anywhere further in the code:

image

How are the AVD host VM-s set up with FSLogix? Is it part of custom image build, but not committed to the repo?

It looks like only the Bicep variant of the deployment actually performs setting up of host VM-s with FSLogix:

danycontre commented 4 months ago

@mloskot thanks for your feedback, FSLogix setup for terraform is a work in progress under PR 570.

Current storage account references in the code are a preparation for the full FSLogix setup.

mloskot commented 4 months ago

@danycontre Thanks for arriving back with the explanation