Azure / avdaccelerator

AVD Accelerator deployment automation to simplify the setup of AVD (Azure Virtual Desktop) based on best practices
MIT License
330 stars 209 forks source link

WAF compliancy patch for adding DDoS protection plan #605

Closed yahanda closed 2 months ago

yahanda commented 5 months ago

Overview/Summary

Adding DDoS network protection option to be completely WAF compliant as per ADO Items below: https://dev.azure.com/CSUSolEng/Accelerator%20-%20AVD/_workitems/edit/34480/ https://dev.azure.com/CSUSolEng/Accelerator%20-%20AVD/_workitems/edit/34047/

This PR fixes/adds/changes/removes

  1. The DDoS network protection is not enabled by default. We can include in the accelerator the option to enable DDoS protection on the Vnet.

Breaking Changes

  1. Replace me
  2. Replace me

Testing Evidence

Tested from the link below https://portal.azure.com/#blade/Microsoft_Azure_CreateUIDef/CustomDeploymentBlade/uri/https%3A%2F%2Fraw.githubusercontent.com%2Fyahanda%2Favdaccelerator-bicep-edits%2Fwaf-compliancy-patch-3%2Fworkload%2Farm%2Fdeploy-baseline.json/uiFormDefinitionUri/https%3A%2F%2Fraw.githubusercontent.com%2Fyahanda%2Favdaccelerator-bicep-edits%2Fwaf-compliancy-patch-3%2Fworkload%2Fportal-ui%2Fportal-ui-baseline.json

Added checkbox for DDoS network protection image

Deployed successfully image

Successfully added DDoS protection plan on vnet image

As part of this Pull Request I have

danycontre commented 2 months ago

@yahanda thanks for your contribution, please sync changes from Azure/main to your fork/branch and let us now once updated so we can continue the review process.

@swathibhat1 @moisesjgomez

yahanda commented 2 months ago

Hi @danycontre, I have merged the latest main repo into my branch. Please review it.

danycontre commented 2 months ago

@yahanda thanks for you contribution