Azure / avdaccelerator

AVD Accelerator deployment automation to simplify the setup of AVD (Azure Virtual Desktop) based on best practices
MIT License
305 stars 198 forks source link

Fix TF Module References #612

Closed mbrat2005 closed 1 month ago

mbrat2005 commented 2 months ago

Overview/Summary

PS C:\Users\mbratschun\repos\avdaccelerator\workload\terraform\greenfield\AADscenario> terraform init

Initializing the backend...
Initializing modules...
- personal in ..\..\modules\avd\personal
╷
│ Error: Module is incompatible with count, for_each, and depends_on
│ 
│   on main.tf line 68, in module "personal":
│   68:   depends_on     = [module.avdi.avdLocation]
│ 
│ The module at module.personal is a legacy module which contains its own local provider configurations, and so calls to it may not use the count, for_each, or depends_on arguments.
│ 
│ If you also control the module "../../modules/avd/personal", consider updating this module to instead expect provider configurations to be passed by its caller.
╵

This PR fixes/adds/changes/removes

  1. Updated commented module references to include /avd in paths
  2. Remove the empty local provider configuration in the personal module

Breaking Changes

  1. Replace me
  2. Replace me

Testing Evidence

image

image

As part of this Pull Request I have

jensheerin commented 2 months ago

hold merge

danycontre commented 2 months ago

@jensheerin please help us checking this one.

jensheerin commented 2 months ago

@danycontre this will not be merged. The AVM module was used instead. Please close.