Azure / avdaccelerator

AVD Accelerator deployment automation to simplify the setup of AVD (Azure Virtual Desktop) based on best practices
MIT License
330 stars 209 forks source link

Terraform ADDS scenario update for AVM alignment #621

Closed jensheerin closed 3 months ago

jensheerin commented 3 months ago

Overview/Summary

This update modifies the ADDS scenario to use the AVM (aka.ms/avm) models from Terraform registry which are WAF align. Which aims to update the current code and documentation to be completely WAF compliant.

Adds the following AVM modules:

  1. Log Analytics - avm-res-operationalinsights-workspace
  2. Host Pool - avm-res-desktopvirtualization-hostpool
  3. Application Groups - avm-res-desktopvirtualization-applicationgroup
  4. Workspace - avm-res-desktopvirtualization-workspace
  5. Scaling Plan - avm-res-desktopvirtualization-scalingplan
  6. Key Vault - avm-res-keyvault-vault

Breaking Changes

Testing Evidence

  1. Test Configuration: The Terraform configuration files used for the test, include as the sample in the repo.
  2. Test Execution: terraform init, terraform validate, and terraform apply.

image image image

  1. Expected Outcomes: An end-to-end deployment of the AVD LZA spoke workload with all the resources deployed and the session host are joined to AD DS.
  2. Actual Outcomes: Deployment was as expected outcome
  3. Evidence of Test: Provide logs, console outputs, or screenshots as evidence of the test execution and results.

As part of this Pull Request I have