Azure / avdaccelerator

AVD Accelerator deployment automation to simplify the setup of AVD (Azure Virtual Desktop) based on best practices
MIT License
324 stars 207 forks source link

Add support for multiple access groups #626

Closed bhlillevik closed 1 month ago

bhlillevik commented 2 months ago

Overview/Summary

Add option to add more than one AVD Access Group with Bicep and Portal-UI

Co-contributors: This work was done in collaboration with @SimenWO 🥇

This PR addresses parts of issue: https://github.com/Azure/avdaccelerator/issues/625

This PR fixes/adds/changes/removes

  1. Bicep:
    • Support Multiple Access Groups: Added the capability to handle multiple access groups by creating a list of securityPrincipals, and removed the existing parameters securityPrincipalName and securityPrincipalId.
    • Submodule Updates: Updated the submodules for storage and applicationGroups(avdManagementPlane) to support the list of securityPrincipals.
  2. Storage scripts:
    • Parameter Update: Modified the storage scripts to change the parameter from a single string securityPrincipalName to a list of securityPrincipalNames.
    • Permission Assignment: Updated the permission assignment logic to iterate through the securityPrincipalNames list, instead of assigning permissions to a single group.
  3. Portal-UI:
    • EditableGrid element: Enhanced the identityAvdAccess component to include an EditableGrid, allowing users to add more than one group name and ID.
    • Output Update: Updated the output to provide a complete object from identityAvdUserAccessGroups, reflecting the new capability to handle multiple access groups.

Breaking Changes

  1. Multiple Access Groups: The deployment process now supports multiple access groups when using Bicep/ARM templates.
  2. Portal-UI Enhancements: The Portal-UI has been updated to support a list of access groups, when users manually specifies group names and IDs

Testing Evidence

Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

danycontre commented 2 months ago

@bhlillevik thanks for your contribution, please sync your fork/branch from Azure/main, we merged this morning a PR that replaced CARML with AVM and introduced new features.

Once updated please let us know to continue the review process of the PR.

@swathibhat1 @moisesjgomez

bhlillevik commented 1 month ago

Will be replaced.