Closed fangjian0423 closed 1 year ago
@jongio could you please take a look at this template, thanks!
@v-xuto can you do a dry-run on this template and update here for any issues/feedback?
@fangjian0423 We have tested the template todo-java-postgresql-aca-terraform
, we filed one issue (https://github.com/fangjian0423/todo-java-postgresql-aca-terraform/issues/1), please review it.
Please help to add a hint to the README about PostgreSQL
, such as make sure psql command is available in your terminal
.
Besides, when executing the command azd up
is executed, many of the available locations introduced in the README, our subscription Azure SDK Developer Playground
is not allowed to provision in Brazil South, Canada Central, Central US, East Asia, Eastus2, Germany West Central, Japan East, Korea Central, North Central US, North Europe, UK South, West US
for PostGreSQL flexible server
, so we can't help to verify the avaliable locations.
@fangjian0423 Please add relevant hints in README
: Before executing azd pipeline config
, need to execute azd down
and enable remote state according to the document.
@jongio @weikanglim @wbreza please review.
@jongio We have finished testing this template, and there is only a same issue(https://github.com/fangjian0423/todo-java-postgresql-terraform/issues/3) with template todo-java-postgresql-terraform
now. For this issue, we did not file it in this template.
Are we considering adding this into azure/azure-dev repo to generate along side our official repos? If so we should open a PR with these changes.
I also ran into the AAD issue upon deployment. I would recommend we turn off AAD integration on the template if possible.
@jongio @savannahostrowski is it okay for this to be served from https://github.com/fangjian0423/todo-java-postgresql-aca-terraform?
That's fine - if their team wants to move it to Azure-Samples that's up to them!
Closing this in favor of a new ACA template will be added as such - https://github.com/Azure/azure-dev/pull/1792
New azd-template Submission
Fill in the sections below to populate a new Gallery carry for your template. An example of a valid template object is given at the end for reference. All fields are mandatory unless explicitly identified as optional
1. Title
Short template name that will be used in card title on gallery
ToDo Application - Java PostgreSQL Container Apps Terraform
2. Description
1-2 sentence description of the architecture or solution that is defined by the template
A complete ToDo application that includes everything you need to build, deploy, and monitor an Azure solution. This application uses the Azure Developer CLI (azd) to get you up and running on Azure quickly, React.js for the Web application, Java for the API, Azure Database for PostgreSQL - Flexible Server for storage, and Azure Monitor for monitoring and logging.
3. Author Profile
A link to the contributor's GitHub profile (ideal) or other profile link (for identification.
https://github.com/fangjian0423
4. Author Name
The name to be shown in the grey button on the card - will be linked profile website above.
Jimmy Fang
5. Template Repo
The GitHub repo containing the template being contributed - must be a valid, complete template
https://github.com/fangjian0423/todo-java-postgresql-aca-terraform
6. Link to PR where you made your repo
azd
compatibleTo allow us to provide feedback on your template, please include a link to the PR where you added
azd
compatibilityIt's a new project. Could you pls create a new issue if you want to provide feedback.
7. Standard Tags
One or more tags representing the template. Look at the currently available tags on the Gallery page and pick at least 1 tag for programming language used, and 1 tag for Azure services integrated
java
,containerapps
,postgresql
,monitor
,passwordless
,application insights
,terraform
7. Additional Tags (
optional
)Don't see a relevant standard tag for your template? Request these tags be added, and then used for your template. These could be new languages, services, or application domains.
spring
8. Architecture Diagram or Application Screenshot
Used as default image for template card - must be representative of solution being enabled. Submit image by adding it as file upload to this issue
Example Of Valid Template
Next Steps
Once submitted the issue will be reviewed - we plan to do reviews on a rolling basis at regular intervals. The process will involve checking that template information is complete, and the template is valid.