search

Azure / azqr

Azure Quick Review
https://azure.github.io/azqr
MIT License
527 stars 81 forks source link

feature: add Virtual Machine Scale Set scanner #208

Closed vanwinkelseppe closed 6 months ago

vanwinkelseppe commented 6 months ago

Description

Added a basic rule set for Virtual Machine Scale sets

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #108

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

vanwinkelseppe commented 6 months ago

Run documentation command after other merges have happened: @vanwinkelseppe

vanwinkelseppe commented 6 months ago

@cmendible Updated documentation and rebased of main! Ready for review

cmendible commented 6 months ago

@vanwinkelseppe please rebase an re-generate the rules docs so I can merge this one.

vanwinkelseppe commented 6 months ago

@vanwinkelseppe please rebase an re-generate the rules docs so I can merge this one.

@cmendible done!

codecov-commenter commented 6 months ago

Codecov Report

Attention: Patch coverage is 37.68116% with 43 lines in your changes are missing coverage. Please review.

Project coverage is 46.67%. Comparing base (d82d313) to head (4ecea13). Report is 20 commits behind head on main.

Files Patch % Lines
internal/scanners/vmss/vmss.go 0.00% 40 Missing :warning:
internal/scanners/vmss/rules.go 89.65% 2 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #208 +/- ## ========================================== - Coverage 48.44% 46.67% -1.77% ========================================== Files 72 76 +4 Lines 3625 3921 +296 ========================================== + Hits 1756 1830 +74 - Misses 1854 2075 +221 - Partials 15 16 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.