search

Azure / azure-amqp-common-go

Azure AMQP abstractions for Golang contains common types and interfaces for use in Service Bus and Event Hubs.
MIT License
12 stars 25 forks source link

**Breaking Change** remove persist and log packages #36

Closed devigned closed 5 years ago

devigned commented 5 years ago
chrislusf commented 5 years ago

This ForeachKey() is removed. But gocloud has some code depending on this. And my code depends on gocloud.

gocloud.dev/pubsub/azuresb

../../../../gocloud.dev/pubsub/azuresb/azuresb.go:448:9: sbmsg.ForeachKey undefined (type *servicebus.Message has no field or method ForeachKey)

devigned commented 5 years ago

@chrislusf are you using go modules or any other dependency management tool? Based on the go-cloud go.mod file https://github.com/google/go-cloud/blob/b8dfaf7853a9331330711ad36ca187b19d33832c/go.mod#L25, they should be pinned to service bus v0.7.0 and should not be broken if using go modules.

I'll look at opening a pull request to go-cloud to resolve this with v0.8.0.

Please also keep in mind that while this project is below v1, we do reserve the ability to change the interface, and to properly insulate your self from these changes, we highly recommend using some form of dependency management.

devigned commented 5 years ago

@chrislusf this PR should resolve the issue you are running into. I'm sorry if this was a painful experience.

I highly encourage your to use Go modules, if you are not already, to have more control over your dependencies, particularly when the dependencies include modules versions < v1.x.x.