doRPCWithRetry() string-izes errors that come back from the call

Azure / azure-amqp-common-go

Azure AMQP abstractions for Golang contains common types and interfaces for use in Service Bus and Event Hubs.

MIT License

12 stars 25 forks source link

doRPCWithRetry() string-izes errors that come back from the call #59

Closed richardpark-msft closed 1 year ago

richardpark-msft commented 2 years ago

DoRPCWithRetry() doesn't return the actual response from the remote service, which results in clients having to do string matches against the returned error.

The base cause is that .Retryable() error itself is a string, and that's what DoRPCWithRetry uses for flow control in it's retry mechanism.

This can be fixed, but we probably want to take some care that we don't break any parts of the interface.

richardpark-msft commented 1 year ago

Not anymore it doesn't! Fixed quite awhile ago.