search

Azure / azure-amqp

AMQP C# library
Other
94 stars 70 forks source link

A legacy mode value is found in the `Source`'s `Filter` when creating a session receiver using `accept_next_session` #232

Closed minghuaw closed 1 year ago

minghuaw commented 1 year ago

This is a follow-up to #231. Though the service now accepts a described value as the SessionFilter, when creating a session receiver using accept_next_session (ie. letting the service decide the session ID), the Attach sent from the service to client still carries a legacy mode SessionFilter (ie. a non-described string).

I would imagine this may introduce incompatibilities to existing client SDKs, so I am just curious whether this would be fixed in the near future?

mario-guerra commented 1 year ago

@xinchen10 could you please look into this issue and help answer Michael's question? He's helping us develop an AMPQ-compatible service bus crate for the Rust SDK and this issue has come up during development.

xinchen10 commented 1 year ago

I have informed the service team about this issue. I will follow up with them for possible solutions but given that changing the type will break the existing clients, it is going to be tricky.

mario-guerra commented 1 year ago

@xinchen10 thank you.

minghuaw commented 1 year ago

I already have an implementation that could work with the legacy format. I could totally adopt this implementation if changing the service is going to be tricky

mario-guerra commented 1 year ago

Hi @xinchen10, have you received any feedback from the service team regarding potential solutions to this issue?

xinchen10 commented 1 year ago

The service team is aware of this issue. If you need further assistance, please contact them under the service bus sdk repo.