search

Azure / azure-amqp

AMQP C# library
Other
94 stars 70 forks source link

Dispose CancellationTokenSource in Singleton OpenAsync with a timeout #234

Closed danielmarbach closed 1 year ago

aarondandy commented 1 year ago

@xinchen10, what is the preferred way to get a fix like this on both the v2 and v3 branches?

danielmarbach commented 1 year ago

The test that failed worked locally. It also seems that the build script swallows the exit code in some cases. I'm happy to send in another PR after the other two that bumps some refs are merged

danielmarbach commented 9 months ago

@xinchen10 any reasons why this was not brought to the hotfix branch and released?

xinchen10 commented 9 months ago

Hi @danielmarbach, this issue does not exist in hotfix branch where timeout is handled differently.