search

Azure / azure-c-shared-utility

Azure C SDKs common code
Other
111 stars 203 forks source link

tlsio support for http proxy io #512

Closed yunhaoling closed 2 years ago

ericwolz commented 3 years ago

please add unit tests to https://github.com/Azure/azure-c-shared-utility/blob/master/tests/http_proxy_io_ut/http_proxy_io_ut.c

yunhaoling commented 3 years ago

hey @ericwol-msft, I tried to add two tests.

however, I don't know how to give a default value to the bool variable (true/false) in the struct -- I guess it's not supported in C. I find that during runtime a random true/false could be assigned to the variable, do you know how to resolve the issue in a non-breaking way?

ericwolz commented 3 years ago

yes, this is an issue. You should use http_proxy_io_set_option() to extend the http functionality and not change the io_create_parameters. Move use_tls_proxy to HTTP_PROXY_IO_INSTANCE and add a new option name/value that can be passed in to see this value.

@ewertons

jessek commented 3 years ago

@yunhaoling: Looks like there is some feedback and suggestions on the code. Can you please update the PR to reflect the requested changes? We are excited to have this capability!

yunhaoling commented 3 years ago

hey @jessek , thanks for checking! I was tied up with some python sdk issues last month, but I should have some free cycles this month and will continue the implantation on this one.

yunhaoling commented 2 years ago

closing the PR for now, but we could reactive this in the future if there's new customer wanting it