search

Azure / azure-c-shared-utility

Azure C SDKs common code
Other
111 stars 203 forks source link

hmac.c: fix mismatching function prototype #537

Closed fgiancane8 closed 3 years ago

fgiancane8 commented 3 years ago

The reported function raises a warning when compilers assert the flag -Warray-parameter=, signaling that an array-type argument was promoted to a pointer-type argument.

While in practice in most C implementations this is correct, fixing the warning (and, in this case, indicating the maximum size for the array) would represent a best-practice for finding out-of-bound accesses or identifying wrongly-sized arrays passed in the function.

Signed-off-by: Francesco Giancane francesco.giancane@accenture.com

danewalton commented 3 years ago

/azp run

azure-pipelines[bot] commented 3 years ago
Azure Pipelines successfully started running 1 pipeline(s).
danewalton commented 3 years ago

thanks for the contribution @fgiancane8 !

fgiancane8 commented 3 years ago

@danewalton ,

You're welcome :) thank you!