search

Azure / azure-c-shared-utility

Azure C SDKs common code
Other
111 stars 203 forks source link

Do not pass MSG_NOSIGNAL as flag to `recv` #606

Closed AndWass closed 1 year ago

AndWass commented 1 year ago

Related issue: https://github.com/Azure/azure-c-shared-utility/issues/605

danewalton commented 1 year ago

Hi @AndWass The flag for MSG_NOSIGNAL was explicitly added in this PR: https://github.com/Azure/azure-c-shared-utility/pull/479

It should only suppress the SIGPIPE error, reducing the number of errors this would actually generate. This change, as I understand, would create more error scenarios.

https://www.man7.org/linux/man-pages/man2/send.2.html

I stand corrected! I was looking at send(). Let me look into this further and get back to you.

danewalton commented 1 year ago

https://www.man7.org/linux/man-pages/man2/recv.2.html

Doesn't seem to be a flag for recv()

AndWass commented 1 year ago

That was my reading/take on it as well.

danewalton commented 1 year ago

/azp run

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 1 pipeline(s).