Azure / azure-capi-cli-extension

Kubernetes Cluster API support in the Azure CLI
MIT License
20 stars 18 forks source link

Improve kind install helper #171

Closed mboersma closed 1 year ago

mboersma commented 1 year ago

Description

The install_kind function defaulted to an old version and wasn't taking into account the platform architecture. This fetches the latest official release for the correct architecture.

I would default to "latest" instead of hard-coding a version, but that gets us a prerelease version:

% ./env/bin/kind version                                    
kind v0.18.0-alpha+7d26b50a129faf go1.19.3 darwin/arm64

I think it's safer to pin to a known-working version and update periodically than to use alpha builds of kind.

I've tested this locally.

History Notes


This checklist is used to make sure that common guidelines for an Azure CLI pull request are followed.

mboersma commented 1 year ago

/hold

Need to test on an x86_64 platform.

mboersma commented 1 year ago

/hold cancel (yes, I know there's no bot here to process this command, but there should be)

Test on Mac amd64 and Linux x84_64.