Azure / azure-capi-cli-extension

Kubernetes Cluster API support in the Azure CLI
MIT License
20 stars 17 forks source link

Updating az capi to store name of aks infrastructure resource group and the aks vnet as environment variables #184

Closed bingbing8 closed 1 year ago

bingbing8 commented 1 year ago

Description Updating az capi to store name of aks infrastructure resource group and the aks vnet as environment variables. They are needed for the scenario that the traffic from internet to k8s API server port 6443 is blocked by a network security group. The solution to that is to run k8s e2e tests in a pod on the aks worker node. This requires that aks cluster and k8s client either in the same vnet or in peered vnets. After aks cluster is created, store the aks infrastructure resource group name and the vnet name so that we can use them when peering the aks vnet and k8s vnet later in the template file. Also add sshd to devcontainer.json so the binaries can be copied out of the container.

History Notes Updating az capi to store name of aks infrastructure resource group and the aks vnet as environment variables


This checklist is used to make sure that common guidelines for an Azure CLI pull request are followed.

jsturtevant commented 1 year ago

@mboersma looks like linter error due to large module. Should we split out some of the functionality or skip linter error for this?

mboersma commented 1 year ago

C0302: Too many lines in module (1021/1000)

We have hit this several times before and taken it as an opportunity for refactoring code out of custom.py into the other modules. That would be best, although it would require more than just moving find_resource_group_name_of_aks_infrastructure elsewhere, since apparently the file is at 999 lines already. :-|

So we could just add pylint: disable=too-many-lines to this PR. I created issue #185 to track refactoring of custom.py separately (it was already a problem before this PR).

@bingbing8 thanks for the PR! Let me know if this makes sense.

mboersma commented 1 year ago

Also, you can test your linting changes locally with azdev style.

marosset commented 1 year ago

also please squash commits once this is ready for merging

bingbing8 commented 1 year ago

C0302: Too many lines in module (1021/1000)

We have hit this several times before and taken it as an opportunity for refactoring code out of custom.py into the other modules. That would be best, although it would require more than just moving find_resource_group_name_of_aks_infrastructure elsewhere, since apparently the file is at 999 lines already. :-|

So we could just add pylint: disable=too-many-lines to this PR. I created issue #185 to track refactoring of custom.py separately (it was already a problem before this PR).

@bingbing8 thanks for the PR! Let me know if this makes sense.

Thanks @mboersma. How to add pylint: disable=too-many-lines to this PR?

mboersma commented 1 year ago

@bingbing8, at the top of the custom.py file there is this line:

# pylint: disable=missing-docstring

You can change it to:

# pylint: disable=missing-docstring,too-many-lines